Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed model cleanup on cluster #2683

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fixed model cleanup on cluster #2683

merged 2 commits into from
Jan 6, 2025

Conversation

kartik4949
Copy link
Collaborator

Description

Related Issues

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@kartik4949 kartik4949 force-pushed the fix/model/cleanup branch 2 times, most recently from cc1a4b1 to 8114119 Compare December 11, 2024 09:09
jieguangzhou
jieguangzhou requested changes Dec 30, 2024
View reviewed changes
superduper/templates/__init__.py Show resolved Hide resolved
superduper/components/model.py Outdated Show resolved Hide resolved
@kartik4949 kartik4949 force-pushed the fix/model/cleanup branch 5 times, most recently from 61b1e8e to 4a9b277 Compare January 3, 2025 07:44
@blythed blythed merged commit 2348bee into superduper-io:main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieguangzhou jieguangzhou jieguangzhou requested changes

@blythed blythed blythed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartik4949 @blythed @jieguangzhou