Label component #723
Open
Label component #723
+117
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add navigation * changes after review * fix lint * chages after review
|
hi @dzonidoo can you update the PR? |
petrjasek
reviewed
Apr 10, 2024
| type?: 'default' | 'success' | 'warning' | 'alert' | 'info' | 'highlight'; | ||
| size?: 'small' | 'medium' | 'big'; | ||
| style?: 'fill' | 'hollow' | 'translucent'; // defaults to 'fill' | ||
| className?: string; |
* add navigation * changes after review * fix lint * chages after review
petrjasek
reviewed
Feb 6, 2025
| text: string; | ||
| type?: 'default' | 'success' | 'warning' | 'alert' | 'info' | 'highlight'; | ||
| size?: 'small' | 'medium' | 'big'; | ||
| style?: 'fill' | 'hollow' | 'translucent'; // defaults to 'fill' |
There was a problem hiding this comment.
I don't see hollow being used at all, if fill is default, I wonder if it wouldn't be better to handle it as param like:
default: <Label ... />
translucent: <Label translucent ... />
but if this is somehow consistent with other components I don't mind
| }, this.props.className); | ||
|
|
||
| return ( | ||
| <span className={classes}> |
There was a problem hiding this comment.
I wonder why not use label tag if it's called a label, in case this is not input label we should probably call it something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHUB-468
Checklist
lodash.getwith optional chaining for modified code segments