Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement change password in user profile #664

Merged
merged 2 commits into from
Nov 23, 2023
Merged

implement change password in user profile #664

merged 2 commits into from
Nov 23, 2023

Conversation

petrjasek
Copy link
Member

in case the auth provider supports it.
also move the firebase auth integration to core.

CPCN-206

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@petrjasek
implement change password in user profile
b485b7e 
in case the auth provider supports it.
also move the firebase auth integration to core.

CPCN-206
@petrjasek petrjasek requested a review from MarkLark86 November 22, 2023 17:42
@petrjasek petrjasek added this to the v2.6 milestone Nov 22, 2023
@petrjasek petrjasek mentioned this pull request Nov 22, 2023
Merged
MarkLark86
MarkLark86 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, only a couple small things

assets/auth/firebase/change_password.ts Show resolved Hide resolved
assets/components/TextInput.tsx Outdated Show resolved Hide resolved
assets/reducers.ts Outdated Show resolved Hide resolved
assets/user-profile/components/profile/UserProfile.tsx Outdated Show resolved Hide resolved
assets/user-profile/components/profile/UserProfile.tsx Outdated Show resolved Hide resolved
newsroom/auth/providers.py Outdated Show resolved Hide resolved
newsroom/auth/views.py Outdated Show resolved Hide resolved
assets/auth/firebase/reset_password.ts Outdated Show resolved Hide resolved
@petrjasek petrjasek requested a review from MarkLark86 November 23, 2023 14:11
@MarkLark86 MarkLark86 merged commit 5616946 into superdesk:develop Nov 23, 2023
7 checks passed
@petrjasek petrjasek deleted the feat-change-password-v2 branch November 24, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@petrjasek @MarkLark86