fix display of empty topics message #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it's visible based on selected my/company topics. CPCN-415
thecalcc
approved these changes
Oct 26, 2023
| @@ -259,7 +261,7 @@ class PersonalizeHomeModal extends React.Component<IProps, IState> { | |||
| { | |||
| gettext( | |||
| '{{size}} out of 6 topics selected', | |||
| {size: this.state.selectedTopicIds.length} | |||
| {size: this.state.selectedTopicIds.length || '0'} | |||
There was a problem hiding this comment.
I think it'd be better if you used ??
There was a problem hiding this comment.
Also since length is a number why is the fallback a string?
There was a problem hiding this comment.
found the problem why it didn't work, it was in the gettext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it's visible based on selected my/company topics.
CPCN-415
Checklist