wire - topic e2e test #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,12 +96,15 @@ export function TopicFolder({ | |||
| <button | |||
| type="button" | |||
| className="icon-button icon-button--tertiary" | |||
| data-test-id="simple-card-toggle-btn" | |||
There was a problem hiding this comment.
improve data-test-id - call it "expand"
| @@ -121,7 +125,9 @@ export function TopicFolder({ | |||
| }} | |||
| ref={buttonRef} | |||
| className="icon-button icon-button--tertiary" | |||
| aria-label={gettext('Folder Actions')}> | |||
| aria-label={gettext('Folder Actions')} | |||
| data-test-id={`folder-action-${folder.name}`} | |||
There was a problem hiding this comment.
data-test-id={folder-action-${folder.name}} -> data-test-id="menu" (or remove if unused)
| @@ -47,6 +47,7 @@ export function TopicFolderActions({folder, toggleFolderPopover, folderPopover, | |||
| toggle(e); | |||
| action.callback(); | |||
| }} | |||
| data-test-id={`action-topic-${action.name}`} | |||
There was a problem hiding this comment.
remove all usages of dynamic data-test-id
| profileTopics.getTopicCardAction("Topic 1", "Edit").click(); | ||
| UserTopicForm | ||
| .getFormGroup('folder', '[data-test-id="dropdown-btn"]') | ||
| .contains('New Folder'); |
| UserTopicForm | ||
| .getFormGroup('folder', '[data-test-id="dropdown-btn"]') | ||
| .contains('New Folder'); | ||
| cy.get('[data-test-id="profile-content-close"]').click(); |
There was a problem hiding this comment.
improve naming -> profile-page-close
Comment on lines
175
to
187
| // check Share with my company checkbox | ||
| cy.get('[data-test-id="field-is_global"] input').check(); | ||
| UserTopicForm | ||
| .getFormGroup('folder', '[data-test-id="dropdown-btn"]').click() | ||
| cy.get('[data-test-id="dropdown-item--Folder 1"]').should("not.exist"); | ||
| cy.get('[data-test-id="dropdown-item--company folder"]').should("exist"); | ||
|
|
||
| // uncheck Share with my company checkbox | ||
| cy.get('[data-test-id="field-is_global"] input').uncheck(); | ||
| UserTopicForm | ||
| .getFormGroup('folder', '[data-test-id="dropdown-btn"]').click() | ||
| cy.get('[data-test-id="dropdown-item--Folder 1"]').should("exist"); | ||
| cy.get('[data-test-id="dropdown-item--company folder"]').should("not.exist"); |
There was a problem hiding this comment.
extract into a separate test
|
|
||
| // save to folder | ||
| cy.get('[data-test-id="dropdown-item--Folder 1"]').click(); | ||
| cy.get('[class="nh-button nh-button--primary"]').click(); |
|
|
||
| // check if folder exist in appropriate folder in My Wire Topics | ||
| cy.get('[data-test-id="edit-btn"]').click(); | ||
| profileTopics.getFolderCard("Folder 1").find('[data-test-id="simple-card-toggle-btn"]').click(); |
There was a problem hiding this comment.
fix naming of data-test-id
| NewshubLayout.login('[email protected]', 'admin'); | ||
| navigateToMyWireTopic(); | ||
|
|
||
| profileTopics.getFolderCard("Folder 1").find('[data-test-id="simple-card-toggle-btn"]').click(); |
There was a problem hiding this comment.
fix naming of data-test-id
| navigateToMyWireTopic(); | ||
|
|
||
| // remove topic from folder | ||
| profileTopics.getFolderCard("Folder 1").find('[data-test-id="simple-card-toggle-btn"]').click(); |
There was a problem hiding this comment.
fix naming in data-test-id
assets/components/SidebarFolder.jsx
Outdated
| @@ -6,7 +6,7 @@ export function SidebarFolder({folder, children}) { | |||
|
|
|||
| return ( | |||
| <div className={`collapsible-box collapsible-box--active-within ${open ? 'collapsible-box--open' : 'collapsible-box--closed'}`}> | |||
| <div className="collapsible-box__header" onClick={() => setOpen(!open)} role='button'> | |||
| <div className="collapsible-box__header" onClick={() => setOpen(!open)} role='button' data-test-id="collapse-box-button"> | |||
There was a problem hiding this comment.
data-test-id is called collapse, but in code is doing toggling, not collapsing - adjust the name to match implementation.
| @@ -47,6 +47,8 @@ export function TopicFolderActions({folder, toggleFolderPopover, folderPopover, | |||
| toggle(e); | |||
| action.callback(); | |||
| }} | |||
| data-test-id="action-folder" | |||
| data-test-value={`${action.name}`} | |||
There was a problem hiding this comment.
don't use interpolation where it's not needed
| @@ -3,7 +3,7 @@ import PropTypes from 'prop-types'; | |||
|
|
|||
| export function TopicItem({topic, isActive, onClick, newItems}: any) { | |||
| return ( | |||
| <li className="topic-list__item"> | |||
| <li className="topic-list__item" data-test-id={`topic-list-item-${topic.label}`}> | |||
There was a problem hiding this comment.
don't use dynamic data-test-id
tomaskikutis
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHUB-405