-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade resources and services to async [CPCN-1022] #1237
Open
devketanpro
wants to merge
27
commits into
superdesk:async
Choose a base branch
from
devketanpro:CPCN-1022
base: async
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,282
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eos87
requested changes
Feb 17, 2025
MarkLark86
reviewed
Feb 18, 2025
This comment was marked as resolved.
This comment was marked as resolved.
MarkLark86
reviewed
Feb 19, 2025
Depends on #1240 to fix breaking change from superdesk-core |
MarkLark86
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple tiny things left now then it will be good to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade and override core modules (Companies, Navigations, Products, Topics, Users) for MGMT api
What has changed
Implemented custom CP modules for MGMT:
Companies (added country field), Navigations, Products, Topics, Users.
Resolves: #CPCN-1022
Currently investigating into the following issues:
Users search (case-insensitive): -
FIXED
Searching for users by email does not return results.
Authentication in resources:
FIXED
Disabling
auth=False
inRestEndpointConfig
results in a 500 authentication error.