Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing test due to changes in #1221 #1228

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix failing test due to changes in #1221 #1228

merged 1 commit into from
Jan 23, 2025

Conversation

petrjasek
Copy link
Member

Purpose

What has changed

Steps to test

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

Resolves: #[issue-number]

@petrjasek petrjasek requested a review from devketanpro January 22, 2025 10:15
@petrjasek petrjasek added this to the v2.9 milestone Jan 22, 2025
@petrjasek petrjasek requested a review from MarkLark86 January 22, 2025 10:30
@petrjasek petrjasek merged commit c74940b into superdesk:release/2.9 Jan 23, 2025
8 checks passed
@petrjasek petrjasek deleted the fix-failing-test branch January 23, 2025 08:00
devketanpro pushed a commit to devketanpro/newsroom-core that referenced this pull request Jan 29, 2025
@petrjasek @devketanpro
fix failing test due to changes in superdesk#1221 (superdesk#1228)
af5b448
devketanpro pushed a commit that referenced this pull request Jan 29, 2025
@petrjasek @devketanpro
fix failing test due to changes in #1221 (#1228)
1f4fa25
devketanpro pushed a commit that referenced this pull request Jan 29, 2025
@petrjasek @devketanpro
fix failing test due to changes in #1221 (#1228)
29071ca
devketanpro added a commit that referenced this pull request Jan 30, 2025
@devketanpro
Update templates to add URLs and fix missing related_events [STT-54] (#…
1006d97 
…1229)

* Update templates to add URLs and fix missing related_events [STT-54]

* fix topic notification

* reformat code

* fix failing test due to changes in #1221 (#1228)

* minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devketanpro devketanpro devketanpro approved these changes

@MarkLark86 MarkLark86 Awaiting requested review from MarkLark86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@petrjasek @devketanpro