[NHUB-611] fix: Exception raised when selecting all products when value is currently null #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue is currently null
devketanpro
added a commit
that referenced
this pull request
Dec 17, 2024
* [NHUB-570] fix(types): Make MonitoringProfile schedule optional (#1171) * [NHUB-550] Upgrade NewsApiAudit resource to async (#1170) * [NHUB-550] Upgrade NewsApiAudit resource to async * fix api_audit resource registration * [NHUB-595] fix(celery): Dont use async for task.apply_async in celery beat (#1174) * [NHUB 549] Implement new formatters registration, convert to async (#1172) * [NHUB-550] Upgrade NewsApiAudit resource to async * fix api_audit resource registration * [NHUB-549] Implement new formatters registration, convert to async * Remove `download_formatters` from app * fix typo in feature product description * [NHUB-564] fix(ws): topic_matches message not including topic ids (#1176) * [NHUB-594] fix(dashboard): Remove validation for card_item requests (#1181) * [NHUB-598] fix(push): Support unknown fields for Wire & Agenda (#1180) * [NHUB-598] fix(push): Support unknown fields for Wire & Agenda * fix type error * remove unused import * FINALLY fix notification length test being flaky * fix update products, use Pydantic models instead of dicts * improve(login): Remove email validation and incorrect login error (#1177) * improve: Use new async signal system (#1182) * improve: Use new async signal system * remove comment in test code * [NHUB-595] fix(command): Get User ID from ResourceModel (#1186) * [NHUB-595] fix(command): Get User ID from ResourceModel * fix lint issue * remove checking lint in unit tests job * [NHUB-550|NHUB-549] fix: NewsAPI audit report & time limit setting (#1189) * fix(reports): Invalid elastic query for NewsAPI audit report * fix(newsapi): Ignore NewsAPI time limit days if 0 * Fix tests (#1200) * update dev-requirements.txt * Remove dataclass wrapper from Dataclass models * [NHUB-600] fix(search): Exclude SectionFilters that are disabled (#1198) * [NHUB-600] fix(search): Exclude SectionFilters that are disabled * update dev-requirements.txt * Remove dataclass wrapper from Dataclass models * [NHUB-587] fix(events): Make sure to store dates with timezone info (#1201) * [NHUB-587] fix(events): Make sure to store dates with timezone info * fix tests * [NHUB-592] fix: User profile not showing if user has no product permissions (#1199) * [NHUB-611] fix: Exception raised when selecting all products when value is currently null (#1208) * fix: Exception raised with agenda push notifications (#1209) * update dev-requirement.txt --------- Co-authored-by: MarkLark86 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In front-end code we're assuming
User.productsalways has a value, which is not always the case, it may sometimes benull. This causes an issue with theSelect Allbutton in Company Admin -> EditUser form.Notes:
What has changed
productsfieldChecklist
lodash.getwith optional chaining for modified code segmentsResolves: NHUB-611