This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: expand associations for single GET (salesforce + hubspot only) #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdfryan
requested review from
tomkit,
lucasmarshall,
tonyxiao and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
asdfryan
commented
Dec 12, 2023
| records: records.map((record) => ({ | ||
| ...record, | ||
| raw_data: | ||
| includeRawData && fieldMappingConfig ? toMappedProperties(record.raw_data, fieldMappingConfig) : undefined, |
There was a problem hiding this comment.
We are reading synced data, which is already mapped. No need to map it again.
lucasmarshall
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of expanding associations.
This also includes a large refactor to move
includeRawDatato the service / provider layers.This also fixes a bug where we were performing schema mapping twice for managed data. (The synced data is already mapped, so no need to map it again)
TODO: