Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version to 0.1.17 #173

Merged
merged 1 commit into from
Oct 12, 2023
Merged

chore: bump version to 0.1.17 #173

merged 1 commit into from
Oct 12, 2023

Conversation

imor
Copy link
Contributor

@imor imor commented Oct 12, 2023

Bump version to prepare for release.

@kamilogorek
Copy link
Member

Should https://github.com/supabase/wrappers/blob/main/supabase-wrappers-macros/Cargo.toml be also updated to keep versions in sync?

@imor
Copy link
Contributor Author

imor commented Oct 12, 2023

Should https://github.com/supabase/wrappers/blob/main/supabase-wrappers-macros/Cargo.toml be also updated to keep versions in sync?

No, supabase-wrappers-macros and supabase-wrappers are the "framework" crates which the wrappers crate depends on. Their version should be bumped only when they are released as a crate (which we should do sometime soon since we have had breaking API changes in them recently). It is ok to not update because we have a path based dependency on them, instead of a version dependency:

supabase-wrappers = { path = "../supabase-wrappers", default-features = false }

Having said that, I think it is a good idea to depend on a specific version of the supabase-wrappers crate because it allows us to dogfood the crate better. I have created an issue to track it here.

Thanks for the feedback @kamilogorek 🙏.

@imor imor merged commit e25c40c into main Oct 12, 2023
@imor imor deleted the bump_version branch October 12, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants