ft: improve socket metrics gathering #378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
ft/improve-socket-metrics-gathering
branch
2 times, most recently
from
50369d9 to
0e07281
Compare
As we are only interested in just 2 of the values from the socket stats, fetch only these. This should reduce time required for processing data sent between port and application. It also simplifies pattern matching and data extraction.
hauleth
force-pushed
the
ft/improve-socket-metrics-gathering
branch
from
0e07281 to
46eefda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Performance improvement.
What is the current behavior?
We fetch all statistics about socket while we are interested only in 2 values.
What is the new behavior?
Fetch only used values.