ft: do not traverse whole state for actions handling #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
ft/actions-handling-traverse
branch
from
292e67f to
bd889ef
Compare
hauleth
force-pushed
the
ft/actions-handling-traverse
branch
from
bd889ef to
c5c99b7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Performance fix
What is the current behavior?
We traverse whole state each time we want to compute whether we want to enable
any timeouts. It causes measurable performance hit. As it is map and we know
only that there is only limited set of keys that can affect timeouts it is
better to access it directly.
What is the new behavior?
Access only required fields. It also makes that function performance less
dependant on state size.