chore: use or instead of ||
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
chore/use-or-instead-of-pipes
branch
from
b515458 to
91df94f
Compare
hauleth
force-pushed
the
chore/use-or-instead-of-pipes
branch
5 times, most recently
from
563458a to
24f2bec
Compare
Reason for that is that `a || b` will expand to: ``` case a do val when val in [false, nil] -> b val -> val end ``` Which is harder to optimise by the compiler. `or/2` works only with booleans, so in places where we do not care about returned value or `nil` cases, it is better to use `or/2`.
hauleth
force-pushed
the
chore/use-or-instead-of-pipes
branch
from
24f2bec to
2a59c0e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Replace uses of
||withorin cases where both sides of operator are forsure boolean.
Reason for that is that
||works on other values than boolean, which mean thata || bis translated to:Which needs to perform more tests and cannot be optimised that easily by the
compiler. New code should be easier for compiler to optimise.