ft: add struct for ClientHandler state
#369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
ft/add-struct-fro-ClientHandler-state
branch
2 times, most recently
from
943a76a to
58b9b49
Compare
This is used to allow Elixir compiler to provide minuscule optimisation,
as with `%{} = data` it will no longer need to check if `data` is an
atom when doing `data.foo`. It also makes it harder to accidentally
access non-existing field as new Elixir versions can check accessed
fields names.
hauleth
force-pushed
the
ft/add-struct-fro-ClientHandler-state
branch
from
58b9b49 to
dd7e376
Compare
|
Let's postpone this. It adds complexity with hot code upgrades, and I think the struct will add latency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds struct for keeping
ClientHandlerstate.Additional context
This approach allows newer Elixir versions to optimise code better, like for
example avoiding tests for whether passed argument is a map (it has to, as it
was already checked in the function head). It also allows compiler to catch at
compile time that you have accessed or you try to update incorrect field
(because of typo).