Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Realtime set auth on handleTokenChanged #1341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filipecabaco
Copy link
Contributor

What kind of change does this PR introduce?

Realtime set auth on handleTokenChanged

@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12403287263

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 67.308%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SupabaseClient.ts 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/SupabaseClient.ts 1 66.67%
Totals Coverage Status
Change from base Build 12389444550: -0.3%
Covered Lines: 99
Relevant Lines: 129

💛 - Coveralls

@salmoro
Copy link

salmoro commented Dec 19, 2024

Thanks @filipecabaco

If this solves what I think it does then it's huge.
We've been noticing nvalidJWTToken: Invalid value for JWT claim "exp" with value {number} from realtime in our app which will randomly kill our users' sessions.
Seems like this should fix it.

@filipecabaco
Copy link
Contributor Author

Hey @salmoro , yes I think this will help but it's not enough.. I might need to do some more changes to realtime-js to ensure we send the proper token before subscribe and that might mean a deeper change to the way we subscribe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants