-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check chunkedCookie is string in server client #26
Closed
pfftdammitchris
wants to merge
5
commits into
supabase:main
from
pfftdammitchris:null-chunked-cookie
Closed
fix: check chunkedCookie is string in server client #26
pfftdammitchris
wants to merge
5
commits into
supabase:main
from
pfftdammitchris:null-chunked-cookie
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
changed the title
null check for chunkedCookie in server client
fix: null check for chunkedCookie in server client
Jul 3, 2024
Hey @pfftdammitchris Thanks for the PR! Could we trouble you to quickly run |
Yeah |
hmm I’ll try to file a PR against this so we can get it in |
hf
approved these changes
Aug 28, 2024
hf
changed the title
fix: null check for chunkedCookie in server client
fix: check chunkedCookie is string in server client
Aug 28, 2024
Hey @pfftdammitchris could you please fix the lint issues? |
hf
pushed a commit
that referenced
this pull request
Aug 30, 2024
## What kind of change does this PR introduce? #26 but with prettier Full credit to [pfftdammitchris](https://github.com/pfftdammitchris) for this contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures chunked cookie checks are of the right type.