Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check chunkedCookie is string in server client #26

Closed

Conversation

pfftdammitchris
Copy link

@pfftdammitchris pfftdammitchris commented Jul 1, 2024

Ensures chunked cookie checks are of the right type.

image

@J0 J0 force-pushed the null-chunked-cookie branch from db411e1 to 04d85f0 Compare July 3, 2024 18:14
@J0 J0 changed the title null check for chunkedCookie in server client fix: null check for chunkedCookie in server client Jul 3, 2024
@J0 J0 force-pushed the null-chunked-cookie branch from 04d85f0 to 247c591 Compare July 3, 2024 18:42
@J0
Copy link
Contributor

J0 commented Jul 3, 2024

Hey @pfftdammitchris

Thanks for the PR! Could we trouble you to quickly run npx prettier --write . when free?

@pfftdammitchris
Copy link
Author

Hey @pfftdammitchris

Thanks for the PR! Could we trouble you to quickly run npx prettier --write . when free?

Yeah

@J0 J0 marked this pull request as draft July 4, 2024 13:25
@J0 J0 marked this pull request as ready for review July 4, 2024 13:25
@J0
Copy link
Contributor

J0 commented Aug 28, 2024

hmm I’ll try to file a PR against this so we can get it in

@hf hf changed the title fix: null check for chunkedCookie in server client fix: check chunkedCookie is string in server client Aug 28, 2024
@hf
Copy link
Collaborator

hf commented Aug 28, 2024

Hey @pfftdammitchris could you please fix the lint issues?

hf pushed a commit that referenced this pull request Aug 30, 2024
## What kind of change does this PR introduce?

 #26 but with prettier


Full credit to [pfftdammitchris](https://github.com/pfftdammitchris) for
this contribution
@hf hf closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants