fix: PASSWORD_RECOVERY event missing #24
Conversation
|
I'm not sure what's going on with the |
|
Yeah I'm not sure - any chance you can rebase and push a commit with |
|
Thanks for the PR btw :) |
I'm sorry to say that I'm not familiar with that process. After a search, it seems you'd typically run the rebase command when on the branch, not
|
|
Perhaps the best option at this point is for me to close this PR and start fresh? |
|
@j4w8n if you could do that it would be perfect. Feel free to tag me there - will approve ASAP. |
|
Closing. Will recreate. |
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? When resetting a user's password with an email template which has a URL defining the `type` value as `recovery`, and using the `verifyOtp` method to process the token_hash and type, the SSR server client's `onAuthStateChange` function does not recognize the `PASSWORD_RECOVERY` event that verifyOtp fires. This prevents the code [here](https://github.com/supabase/ssr/blob/main/src/createServerClient.ts#L199-L205) from running; resulting in the new session not being saved to cookies, and the user is not considered logged in. Fixes #21 ## What is the new behavior? User is logged in. ## Additional context Replaces PR #24 Co-authored-by: Jason Creviston <[email protected]>
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When resetting a user's password with an email template which has a URL defining the
typevalue ofrecoveryand usingverifyOtpin dev code to process thetoken_hashandtype, the SSR server client'sonAuthStateChangefunction does not recognize thePASSWORD_RECOVERYevent thatverifyOtpuses in this case. Therefore the new session does not get saved to storage and the user is not logged in, in order to reset their password.What is the new behavior?
User is logged in.
Additional context
Fixes #21