-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for UDFs as GraphQL queries/mutations #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failed because a function of type char(x) was being cast to `character` instead of `char(x)`. This was because when we load the sql context we do not have the type modifier info to find out what `x` in char(`x`) is for function inputs. As a workaround we cast such vales to text instead.
Yeah, I have read these. Actually these pages influenced a lot of the design choices for our implementation. |
olirice
requested changes
Sep 8, 2023
If a function returning Node returned null, it output a row with every field as null rather than a null top level object.
olirice
reviewed
Sep 18, 2023
olirice
approved these changes
Sep 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
New feature and docs update.
What is the current behavior?
User defined functions are not available through GraphQL.
What is the new behavior?
User defined functions are available as fields on the query and mutation root types.
Additional context
Tasks
Add support for base types:
Add support for composite types:
Misc:
tables->functions
key and use the newfunctions
in sql context for columns extended with functions.account
and a function namedaccountCollection
.Resolves #222