Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/set local name baseurl #2

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

saschTa
Copy link
Contributor

@saschTa saschTa commented Mar 27, 2024

What kind of change does this PR introduce?

Bug fix:

  • this fixes rejected emails by google gmail smtp relay services
  • no localhost HELO message

What is the current behavior?

GoMail uses localhost as HELO message which causes gmail smtp relay and other services to reject emails
go mail behaviour

Issue:
supabase issue gmail smtp relay

What is the new behavior?

dialer now uses base url of project for HELO message which works instead of local host

non working HELO:

read R BLOCK
220 smtp-relay.gmail.com ESMTP m17-20020a5d6a11000000b0033e55077fd9sm4288wru.69 - gsmtp
helo localhost
421-4.7.0 Try again later, closing connection. (EHLO)
421-4.7.0  For more information, go to
421 4.7.0  https://support.google.com/a/answer/3221692 m17-20020a5d6a11000000b0033e55077fd9sm4288wru.69 - gsmtp
read:errno=0

working HELO:

read R BLOCK
220 smtp-relay.gmail.com ESMTP q16-20020a05600c46d000b004146a27d894sm24293wmo.31 - gsmtp
helo smtp-relay.gmail.com
250 smtp-relay.gmail.com at your service

Additional context

Add any other context or screenshots.

SaschTa added 2 commits March 28, 2024 00:15
- this fixes rejected emails by google gmail smtp relay services
- no localhost HELO message
Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschTa thanks for catching this!

@kangmingtay kangmingtay merged commit d5ce795 into supabase:main Mar 28, 2024
kangmingtay added a commit to supabase/auth that referenced this pull request Mar 28, 2024
## What kind of change does this PR introduce?
* upgrades supabase/mailme package to v0.1.0 which contains
supabase/mailme#2
J0 pushed a commit to supabase/auth that referenced this pull request Apr 1, 2024
## What kind of change does this PR introduce?
* upgrades supabase/mailme package to v0.1.0 which contains
supabase/mailme#2
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?
* upgrades supabase/mailme package to v0.1.0 which contains
supabase/mailme#2
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
## What kind of change does this PR introduce?
* upgrades supabase/mailme package to v0.1.0 which contains
supabase/mailme#2
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
## What kind of change does this PR introduce?
* upgrades supabase/mailme package to v0.1.0 which contains
supabase/mailme#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants