Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the container ulimits for reatime #2694

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

avallete
Copy link
Contributor

@avallete avallete commented Sep 18, 2024

What kind of change does this PR introduce?

Remove the plain RLIMIT_NOFILE values to ensure it won't be greater than the host system.

Fixes #2693

What is the current behavior?

What is the new behavior?

Additional context

@coveralls
Copy link

coveralls commented Sep 18, 2024

Pull Request Test Coverage Report for Build 10960705601

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.125%

Totals Coverage Status
Change from base Build 10959895693: 0.0%
Covered Lines: 6455
Relevant Lines: 10736

💛 - Coveralls

internal/utils/docker.go Outdated Show resolved Hide resolved
@avallete avallete marked this pull request as ready for review September 18, 2024 09:55
@avallete avallete requested a review from a team as a code owner September 18, 2024 09:55
@avallete avallete changed the title fix: set the container Ressource Ulimits according to env variables fix: the container ulimits for reatime Sep 20, 2024
@sweatybridge sweatybridge merged commit a0a5d5f into develop Sep 20, 2024
12 checks passed
@sweatybridge sweatybridge deleted the avallete/fix-ulimit-containers-runs branch September 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running supabase start storage and realtime ulimit
3 participants