-
Notifications
You must be signed in to change notification settings - Fork 438
fix error described in issue #1940 by making all tokens DEFAULT '' #1941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macMikey
wants to merge
1
commit into
supabase:master
Choose a base branch
from
macMikey:set-auth-tokens-default-empty
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Comment on lines
+1
to
+12
BEGIN; | ||
|
||
ALTER TABLE auth.users | ||
ALTER COLUMN confirmation_token SET DEFAULT ''; | ||
ALTER TABLE auth.users | ||
ALTER COLUMN recovery_token SET DEFAULT ''; | ||
ALTER TABLE auth.users | ||
ALTER COLUMN email_change_token_new SET DEFAULT ''; | ||
ALTER TABLE auth.users | ||
ALTER COLUMN email_change SET DEFAULT ''; | ||
|
||
COMMIT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do more changes to make this work, mainly dropping NOT NULL and adding a field in set default.
Suggested change
BEGIN; | |
ALTER TABLE auth.users | |
ALTER COLUMN confirmation_token SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN recovery_token SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change_token_new SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change SET DEFAULT ''; | |
COMMIT; | |
BEGIN; | |
ALTER TABLE auth.users | |
ALTER COLUMN confirmation_token DROP NOT NULL; | |
ALTER TABLE auth.users | |
ALTER COLUMN recovery_token DROP NOT NULL; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change_token_new DROP NOT NULL; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change_token_current DROP NOT NULL; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change_sent_at DROP NOT NULL; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change DROP NOT NULL; | |
ALTER TABLE auth.users | |
ALTER COLUMN confirmation_token SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN recovery_token SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change_token_new SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change_token_current SET DEFAULT ''; | |
ALTER TABLE auth.users | |
ALTER COLUMN email_change SET DEFAULT ''; | |
COMMIT; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: make all auth.users tokens fields default empty
fix error authenticating users created via sql functions. the issue causes token generation to fail during the user lookup due to an sql error
#1940