Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set email_verified to true on all identities with the verified email #1902

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

hf
Copy link
Contributor

@hf hf commented Jan 3, 2025

A fix for #1899 undoing changes in #1868.

@hf hf requested a review from a team as a code owner January 3, 2025 19:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12603151782

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 64.743%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/verify.go 3 5 60.0%
Totals Coverage Status
Change from base Build 12597465305: 0.008%
Covered Lines: 9740
Relevant Lines: 15044

💛 - Coveralls

Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hf hf merged commit 307892f into master Jan 6, 2025
3 checks passed
@hf hf deleted the hf/fix-identity-email-verified branch January 6, 2025 16:14
kangmingtay pushed a commit that referenced this pull request Jan 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.168.0](v2.167.0...v2.168.0)
(2025-01-06)


### Features

* set `email_verified` to true on all identities with the verified email
([#1902](#1902))
([307892f](307892f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants