Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add friendly name to enroll response #812

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Nov 15, 2023

What kind of change does this PR introduce?

We introduced friendly name in the response of enroll a while back: supabase/auth#1277

This PR adds the field to the client library response

@J0 J0 marked this pull request as draft November 15, 2023 06:55
@J0 J0 marked this pull request as ready for review November 15, 2023 07:13
src/lib/types.ts Outdated Show resolved Hide resolved
Co-authored-by: Stojan Dimitrovski <[email protected]>
@J0
Copy link
Contributor Author

J0 commented Nov 15, 2023

Ah this probably should be reverted to draft until we deploy

@J0 J0 marked this pull request as draft November 15, 2023 09:38
@J0 J0 marked this pull request as ready for review December 19, 2023 09:30
@J0 J0 requested a review from hf December 19, 2023 18:34
@J0 J0 changed the title chore: add friendly name to response chore: add friendly name to enroll response Jan 19, 2024
@J0 J0 requested a review from kangmingtay January 19, 2024 05:38
src/lib/types.ts Outdated Show resolved Hide resolved
@J0 J0 merged commit 5d4fdb5 into master Jan 19, 2024
2 checks passed
@J0 J0 deleted the j0/add_friendly_name_to_mfa_enroll_resp branch January 19, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants