fix: small improvements/fixes to cookie chunker in ssr #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
commented
Apr 5, 2024
hf
force-pushed
the
hf/microfixes-chunker
branch
from
811283f
to
5c8f38c
Compare
|
One confirmed support ticket that is demonstrating the issues resolved by these changes. |
J0
approved these changes
Apr 8, 2024
kangmingtay
previously requested changes
Apr 9, 2024
There was a problem hiding this comment.
the package doesn't build with pnpm build:ssr
edit: i've fixed the build errors in this commit
kangmingtay
reviewed
Apr 9, 2024
kangmingtay
reviewed
Apr 9, 2024
|
@hf remember to generate a changeset too! |
|
Does this change fix the bug I just submitted? #766 |
hf
force-pushed
the
hf/microfixes-chunker
branch
from
d43a5a9
to
e4e9b0d
Compare
Maybe... |
hf
force-pushed
the
hf/microfixes-chunker
branch
from
e4e9b0d
to
31b8f99
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/improves some edge cases in the cookie chunker for
ssr:deleteChunksnow attempts to delete both the key and potential leftover chunks, instead of deleting the first thing it notices. This should decrease the total size of cookies by removing orphaned chunks, and also is a bit safer in situations where leftover chunks are mistaken as the continuation of other chunks.setItem, and instead do it serially.setItemfirst clears all chunks before setting the new ones.