Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting custom cookie name in createBrowserClient #746

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Mar 5, 2024

What kind of change does this PR introduce?

@jorgebaralt
Copy link

Any reason this is not merged yet? @J0 @kangmingtay

@J0
Copy link
Contributor

J0 commented Apr 6, 2024

Hey @jorgebaralt,

Thanks for checking in. It's been a little busy - we'll need some time to test this to confirm it works as expected. If anyone has the bandwidth to check that this works as expected it might helps speed the review process. We will still need to test it ourselves as well though

@kangmingtay kangmingtay merged commit 8d85be4 into main Apr 9, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/fix-custom-cookie-name branch April 9, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants