Speed Optimizations. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to be overwriting it.
…ns can be re-used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains many macro/micro optimizations. Most notably:
remapinstead of using scipy'smap_coordinates. The opencv implementation is several times faster. If opencv is used, coordinate calculations are also cached, further speeding it up.np.zeroswithnp.empty.np.concatenate/np.split.Bug Fixes
c2ewasn't returning the proper dtype.To be fixed bugs
@ProGamerGov I think there's an off-by-one bug in the y-coordinates when sampling equirectangular images (inside the newly created
EquirecSampler, previously insideequirec_sample). To be fixed in a follow up PR. If you want to update your repo with similar optimizations, all the changes in this PR are purely for speed (I went through all functions with line-profiler).