Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty serializer classes to fix schema generation #817

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

EvilPug
Copy link
Contributor

@EvilPug EvilPug commented Apr 19, 2024

  • Added empty serializer classes
  • Fixed a typo: SingupRequestView -> SignupRequestView

Fixes:
#816

@EvilPug EvilPug changed the title Added empty serializer classes to fix schema generation (#816) Added empty serializer classes to fix schema generation Apr 19, 2024
Copy link
Member

@haxoza haxoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR!

Overall looks good and it probably works in the use case mentioned in #816.

However I'm not sure if in case of Webauthn views there should be set actual serializer classes used in the code - instead of empty ones.

djoser/webauthn/views.py Outdated Show resolved Hide resolved
djoser/webauthn/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tomwojcik tomwojcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIView doesn't really have serializer_class attribute, but that's the approach that's already used in other views as well, so I guess it's fine for now.

I've created this discussion. Feel free to share your feedback.

#818

Thanks for contributing! Only small nitpicks to address.

djoser/webauthn/views.py Outdated Show resolved Hide resolved
djoser/webauthn/views.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/2.2.3@9bf2c65). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/2.2.3     #817   +/-   ##
================================================
  Coverage                 ?   99.03%           
================================================
  Files                    ?       26           
  Lines                    ?      833           
  Branches                 ?        0           
================================================
  Hits                     ?      825           
  Misses                   ?        8           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvilPug EvilPug force-pushed the bugfix/issue-816 branch from b5e82f7 to d6dba8a Compare May 5, 2024 20:07
@tomwojcik tomwojcik merged commit 327a7b5 into sunscrapers:release/2.2.3 Jun 7, 2024
17 checks passed
@tomwojcik
Copy link
Contributor

Thank you! Sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants