-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added empty serializer classes to fix schema generation #817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this PR!
Overall looks good and it probably works in the use case mentioned in #816.
However I'm not sure if in case of Webauthn views there should be set actual serializer classes used in the code - instead of empty ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APIView
doesn't really have serializer_class
attribute, but that's the approach that's already used in other views as well, so I guess it's fine for now.
I've created this discussion. Feel free to share your feedback.
Thanks for contributing! Only small nitpicks to address.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.2.3 #817 +/- ##
================================================
Coverage ? 99.03%
================================================
Files ? 26
Lines ? 833
Branches ? 0
================================================
Hits ? 825
Misses ? 8
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Thank you! Sorry it took so long. |
Fixes:
#816