allows overriding email urls using settings #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 99.02% 99.03%
=======================================
Files 26 26
Lines 821 829 +8
=======================================
+ Hits 813 821 +8
Misses 8 8 ☔ View full report in Codecov by Sentry. |
three new settings have been added to customize the context passed to the email templates, allowing to set urls domain, protocol and site name with ease.
n-borges
force-pushed
the
feat/allow_overriding_email_urls
branch
from
82f1f94 to
0d70bdc
Compare
tomwojcik
approved these changes
Mar 31, 2024
Great!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds three new settings to allow easy url customization in emails.
This has been done adding a new, simple parent class for all
Emailtypes inemails.py, that injects the settings value into the context passed to the actualEmailinstances.I added a couple unit tests in a new module, i hope they are somewhat coherent with your existing test suite.
Thank you all for the work on this project, it really is great!