-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialization logic for the NDCubeSequence
and NDCollection
instances.
#756
Merged
Cadair
merged 7 commits into
sunpy:asdf-support
from
ViciousEagle03:asdf_ndcube_sequence_and_collection
Nov 7, 2024
Merged
Add serialization logic for the NDCubeSequence
and NDCollection
instances.
#756
Cadair
merged 7 commits into
sunpy:asdf-support
from
ViciousEagle03:asdf_ndcube_sequence_and_collection
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@braingram, @Cadair, could you guys please review it. |
7e75454
to
24af793
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Cadair
approved these changes
Nov 6, 2024
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #755