Feature: Possibility to refer to URL instead of IP address #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In my tests, I wanted to control the car through a URL hostname instead of an IP address in the client.py.
I had to change the following:
For users of this feature:
I you use the free version of ngrok, only one port can be open at once with one URL, unless you hack it :-). If you did, you would notice that URLs are different, and your client UI would then require an additional field for the camera URL and port. This is not implemented in this version.
->If you use duckdns, you have both ports reachable, and the interface works.
These limitations are those of your public reachable hostnames and their providers, not the code itself.
Hopefully this will be accepted, I found a use for it in my lab to remotely control the car (not in the same LAN).
Best regards,
Sofiane