[14.0][ADD] project_forecast_line_deadline #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsirintanis
force-pushed
the
14.0-project_forecast_line_deadline
branch
from
08df2f4
to
9f4bde8
Compare
gjotten
approved these changes
Feb 8, 2024
ntsirintanis
force-pushed
the
14.0-project_forecast_line_deadline
branch
from
3bce03a
to
6817b01
Compare
thomaspaulb
reviewed
Feb 22, 2024
| # Set forecast_date_deadline manually | ||
| task.forecast_date_planned_end = "2022-02-01" | ||
| # Dates are not the same anymore | ||
| self.assertNotEqual(task.forecast_date_planned_end, task.date_deadline) |
There was a problem hiding this comment.
Hm, "not the same anymore" could also mean that None was written to the field. Could we, aside from this, also explicitly check for the date that was written?
There was a problem hiding this comment.
Basically we give a value directly on the field in line 23.
There was a problem hiding this comment.
...yes, but we then don't check for that same value. So, we don't test whether the inverse function actually writes that value - we just test whether the result is a different value. (It's nitpicking, I know)
thomaspaulb
reviewed
Feb 22, 2024
ntsirintanis
force-pushed
the
14.0-project_forecast_line_deadline
branch
from
6817b01
to
5517f64
Compare
thomaspaulb
approved these changes
Feb 27, 2024
ntsirintanis
force-pushed
the
14.0-project_forecast_line_deadline
branch
from
5517f64
to
dff7328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.