-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD] project_task_schedule #1
base: 13.0
Are you sure you want to change the base?
Conversation
|
||
{ | ||
"name": "Project Task Schedule", | ||
"version": "13.0.1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13.0.1.0.0
Internal review first, but this looks nice, I think we can directly propose it to OCA and ping Pedro; in https://github.com/OCA/project/issues/768
he is proposing to add the fields to project_timeline
instead of a new module.
"name": "Project Task Schedule", | ||
"version": "13.0.1.0.1", | ||
"category": "Project", | ||
"author": "Sunflower IT, " "Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has some weird apostrophe flavour, did you run pre-commit run -a
? pre-commit
date_range_id = fields.Many2one( | ||
comodel_name="date.range", string="Date range") | ||
start_date = fields.Date("Start Date") | ||
end_date = fields.Date("End Date") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is two new fields, I like date_planned_start
and date_planned_end
, mirroring Enterprise; if we use existing fields, I think date_end
is still there and we can reimplement date_start
which was removed in 13.0. Let's see what Pedro replies on my question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He answered date_start
and date_end
, so let's reimplement date_start and add a default to date_end, and then propose it to him and see what he says
class ProjectProject(models.Model): | ||
_inherit = "project.project" | ||
|
||
enable_task_planning = fields.Boolean("Enable Task Planning?") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date_planned_required
may be better, with a help text of 'When this is enabled, tasks on this project require a start and end date'
related='project_id.enable_task_planning') | ||
date_range_id = fields.Many2one( | ||
comodel_name="date.range", string="Date range") | ||
start_date = fields.Date("Start Date") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this needs a default of today, as well as end date, so that there is always a value in it after it's created for example on timeline
No description provided.