[FIX] Prettier login page for odoobouncer (#2314) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKamaa
force-pushed
the
odoobouncer-2314
branch
from
5a2b7dc
to
0e4077a
Compare
thomaspaulb
requested changes
Feb 23, 2022
nginx-odoo.py
Outdated
| @@ -37,7 +37,7 @@ def get(self): | |||
| if not redirect_url.endswith("/"): | |||
| redirect_url += "/" | |||
| return self.redirect(f"{redirect_url}auth/{session_id}") | |||
| self.render(r"./templates/login.html", **config.theme_params) | |||
| self.render(r"./templates/login-2.html", **config.theme_params) | |||
There was a problem hiding this comment.
@KKamaa We currently have an environment variable for the backgoundcolor; could you create another environment variable called NGINX_ODOO_THEME or something, which defaults to login, but with which you can configure to use another theme?
There was a problem hiding this comment.
@thomaspaulb added the env variable
| </div> | ||
| </div> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
This is the page for the first step, but how about the second step of entering the 2FA code? Is that also using the other theme?
There was a problem hiding this comment.
Added one template for this but support for the env variable incase future templates are added.
KKamaa
force-pushed
the
odoobouncer-2314
branch
from
abe42cd
to
3faa618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added sample of logins to choose from many more can be added as stand by templates for future implementations.