Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floodgate スタイルの読み筋コメントをプレビューする機能 #673

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

sunfish-shogi
Copy link
Owner

@sunfish-shogi sunfish-shogi commented Nov 23, 2023

説明 / Description

#560

Floodgate スタイルの読み筋コメントに対応し、再現ダイアログで閲覧できるようにする。

チェックリスト / Checklist

  • MUST
    • npm test passed
    • npm run lint was applied without warnings
    • changes of /docs/webapp not included (except release branch)
    • console.log not included (except script file)
  • RECOMMENDED (it depends on what you change)
    • unit test added/updated
    • i18n

@sunfish-shogi sunfish-shogi self-assigned this Nov 23, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (eea0ee5) 69.64% compared to head (2e9fe7b) 69.69%.

Files Patch % Lines
src/renderer/store/record.ts 69.56% 2 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   69.64%   69.69%   +0.04%     
==========================================
  Files          98       98              
  Lines       18695    18716      +21     
  Branches     2719     2728       +9     
==========================================
+ Hits        13021    13044      +23     
+ Misses       2968     2957      -11     
- Partials     2706     2715       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunfish-shogi sunfish-shogi merged commit c9f2260 into main Nov 23, 2023
@sunfish-shogi sunfish-shogi deleted the floodgate-comment branch November 23, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants