Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DateInput component #2645

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

New DateInput component #2645

wants to merge 3 commits into from

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Aug 9, 2024

Addresses #ticket-number.

Purpose

input[type="date"] is a rare example of a native element that doesn't meet accessibility requirements and warrants a custom component. The native component also lacks customizability to disable specific dates or enable the selection of a date range.

Approach and changes

Describe how you solved the problem

  • autocomplete for birthdate
  • abstract away dialog? -> leave for later once re-implementing the Modal components

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 3188d3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 11:23am

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 77.97357% with 50 lines in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base (168829d) to head (3188d3b).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...ages/circuit-ui/components/DateInput/DateInput.tsx 77.97% 50 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2645      +/-   ##
==========================================
- Coverage   86.59%   86.51%   -0.08%     
==========================================
  Files         209      209              
  Lines       11884    12084     +200     
  Branches     1499     1523      +24     
==========================================
+ Hits        10291    10455     +164     
- Misses       1540     1576      +36     
  Partials       53       53              
Files with missing lines Coverage Δ
...i/components/PhoneNumberInput/PhoneNumberInput.tsx 90.33% <ø> (ø)
...ages/circuit-ui/components/DateInput/DateInput.tsx 79.16% <77.97%> (+9.16%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant