487 fork research login with m365 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
September 15, 2023 14:52
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## fork6 #371 +/- ##
============================================
- Coverage 27.65% 27.21% -0.44%
- Complexity 2619 2655 +36
============================================
Files 403 413 +10
Lines 10452 10646 +194
============================================
+ Hits 2890 2897 +7
- Misses 7562 7749 +187
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
src/Modules/OAuth/Domain/Settings/Command/UpdateModuleSettingsHandler.php
Outdated
Show resolved
Hide resolved
added 10 commits
September 21, 2023 16:20
tijsverkoyen
approved these changes
Sep 25, 2023
|
|
||
| #[Route('/private/oauth/connect/azure/check', name: 'connect_azure_check', schemes: ['https'])] // @phpstan-ignore-line | ||
| public function connectCheckAction(AzureAuthenticator $authenticator, Request $request) | ||
| { |
There was a problem hiding this comment.
Dit is leeg? If intended, zet mss een comment waarom
| @@ -0,0 +1,3 @@ | |||
| doctrine: | |||
There was a problem hiding this comment.
Is dat nodig als er niks inzit?
jonasdekeukelaere
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Allows the user to login using Microsoft Azure