검색 모달이 올라왔을 때 바텀 네비게이션을 안보이게 함 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoung125
reviewed
Aug 10, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| .wrapper { | |||
| position: fixed; | |||
| z-index: themes.$modal; | |||
| z-index: themes.$bottomSheet; | |||
There was a problem hiding this comment.
전체적인 z-index조정없이 요기만 floating으로 바꾸는 건 어떤가요??
There was a problem hiding this comment.
bottom navigation과 botton sheet는 다른 것 같아서요!
There was a problem hiding this comment.
저 bottom sheet이 그 용도인줄 알았네요
There was a problem hiding this comment.
z-index는 그럼 그대로 두고 float 속성을 주자는 말씀이신가요?
There was a problem hiding this comment.
넵! bottom sheet는 이런 ui를 칭하는데, 아직 저희프로젝트에서는 안쓰이고 있긴합니다.
그래도 나중에 디자인이 수정될 걸 고려해서 놔두었어요
그래서 이부분은 floating이 되어야 하지 않을까 싶습니다
There was a problem hiding this comment.
float 속성은 근데 어떤 값으로 주어야 하나요? 딱 맞는게 없는거같은데
There was a problem hiding this comment.
z-index에 이 변수 말씀드린겁니다...ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
모달이 올라왔을 때 바텀 네비게이션을 보이지 않게 하여 안드로이드에서 키보드와 함께 바텀바가 올라오는 현상을 해결했습니다.