Merge pull request #4823 from sul-dlss/t4820-fix_open

Fix WorkflowStateService.open?

app/services/workflow_state_service.rb

@@ -29,7 +29,7 @@ def open?
     return !accessioning? && !accessioned? if version == 1
 
     # Otherwise, is there an active versionWF?
-    active_version_wf?
+    active_workflow?(workflow: 'versioningWF')
   end
 
   # The following methods were extracted from VersionService.

spec/services/workflow_state_service_spec.rb

@@ -76,21 +76,25 @@
     context 'when > version 1 and there is an active versionWF' do
       let(:version) { 2 }
 
+      let(:workflow_response) { instance_double(Dor::Workflow::Response::Workflow, active_for?: true, complete_for?: false) }
+
       before do
-        allow(workflow_client).to receive(:active_lifecycle).and_return(Time.current)
+        allow(workflow_client).to receive(:workflow).and_return(workflow_response)
       end
 
       it 'returns true' do
         expect(service.open?).to be true
-        expect(workflow_client).to have_received(:active_lifecycle).with(druid:, milestone_name: 'opened', version: '2')
+        expect(workflow_client).to have_received(:workflow).with(pid: druid, workflow_name: 'versioningWF')
       end
     end
 
     context 'when > version 1 and there is not an active versionWF' do
       let(:version) { 2 }
 
+      let(:workflow_response) { instance_double(Dor::Workflow::Response::Workflow, active_for?: true, complete_for?: true) }
+
       before do
-        allow(workflow_client).to receive(:active_lifecycle).and_return(nil)
+        allow(workflow_client).to receive(:workflow).and_return(workflow_response)
       end
 
       it 'returns false' do