Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #80

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Bump dependencies #80

merged 2 commits into from
Jan 19, 2025

Conversation

mochipon
Copy link
Contributor

@mochipon mochipon commented Jan 19, 2025

Summary by Sourcery

Upgrade Poetry to v2 and Python to 3.9+, along with other dependencies. Replace Flake8, Black, and isort with Ruff. Update pre-commit hooks and CI workflows to reflect these changes.

Build:

  • Update Poetry to v2.

CI:

  • Update CI workflows to use Python 3.9+ and drop support for Python 3.8.
  • Update Code Climate action to v9.

Tests:

  • Update test dependencies.

Copy link

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request updates the project's dependencies, including development tools, and adjusts the supported Python versions. It also migrates from isort, black, and flake8 to ruff for linting and formatting.

Class diagram: Project dependencies and requirements

classDiagram
    class ProjectRequirements {
        +python_version: str
        +build_backend: str
        +dependencies: List
    }

    class Dependencies {
        +octodns: ^1.0.0
        +poetry: ^2.0.0
        +pydantic: ^2.0.0
        +pynetbox: ^7.0.0
        +requests: ^2.32.0
        +typing_extensions: ^4.12.0
    }

    class DevDependencies {
        +pre_commit: ^4.0.0
        +pytest: ^8.0.0
        +pytest_cov: ^6.0.0
        +requests_mock: ^1.12.0
        +tox: ^4.0.0
    }

    ProjectRequirements --> Dependencies
    ProjectRequirements --> DevDependencies

    note for ProjectRequirements "Python version upgraded from 3.8+ to 3.9+"
    note for Dependencies "Dependencies versions bumped"
    note for DevDependencies "Moved to poetry.group.dev.dependencies"
Loading

File-Level Changes

Change Details Files
Updated build system and core dependencies.
  • Switched build backend to poetry.core.masonry.api.
  • Updated poetry-core dependency to >=2.0.0,<3.0.0.
  • Updated poetry dependency to ^2.0.0.
  • Updated pydantic dependency to ^2.0.0.
  • Updated pynetbox dependency to ^7.0.0.
  • Updated requests dependency to ^2.32.0.
  • Updated typing-extensions dependency to ^4.12.0.
  • Set python version to >=3.9,<4.0.
  • Moved development dependencies to the [poetry.group.dev.dependencies] section.
  • Added poetry-dynamic-versioning as a required plugin.
pyproject.toml
Updated development dependencies.
  • Updated pre-commit dependency to ^4.0.0.
  • Updated pytest dependency to ^8.0.0.
  • Updated pytest-cov dependency to ^6.0.0.
  • Updated requests-mock dependency to ^1.12.0.
  • Updated tox dependency to ^4.0.0.
pyproject.toml
Migrated to ruff for linting and formatting.
  • Removed isort, black, and flake8.
  • Added ruff for linting and formatting.
  • Updated pre-commit hooks to v5.0.0.
  • Updated mypy pre-commit hook to v1.14.1.
.pre-commit-config.yaml
Updated supported Python versions.
  • Removed Python 3.8 from the supported versions.
  • Added Python 3.12 and 3.13 to the supported versions.
  • Updated tox.ini to include py312 and py313 environments.
  • Updated GitHub Actions CI workflow to include Python 3.12 and 3.13.
  • Updated GitHub Actions CI workflow to include Python 3.14 for the release workflow.
  • Updated codeclimate action to v9.0.0.
pyproject.toml
tox.ini
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mochipon - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Remove Python 3.14 from CI configuration as it has not been released yet. Stick to testing against released Python versions (3.9-3.13).
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mochipon mochipon force-pushed the fix/bump_deps branch 4 times, most recently from c79dfec to 6b75035 Compare January 19, 2025 01:45
Copy link

codeclimate bot commented Jan 19, 2025

Code Climate has analyzed commit 8d3d46b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.6% (-1.8% change).

View more on Code Climate.

@mochipon mochipon merged commit c6d5f39 into main Jan 19, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant