-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #80
Conversation
Reviewer's Guide by SourceryThis pull request updates the project's dependencies, including development tools, and adjusts the supported Python versions. It also migrates from isort, black, and flake8 to ruff for linting and formatting. Class diagram: Project dependencies and requirementsclassDiagram
class ProjectRequirements {
+python_version: str
+build_backend: str
+dependencies: List
}
class Dependencies {
+octodns: ^1.0.0
+poetry: ^2.0.0
+pydantic: ^2.0.0
+pynetbox: ^7.0.0
+requests: ^2.32.0
+typing_extensions: ^4.12.0
}
class DevDependencies {
+pre_commit: ^4.0.0
+pytest: ^8.0.0
+pytest_cov: ^6.0.0
+requests_mock: ^1.12.0
+tox: ^4.0.0
}
ProjectRequirements --> Dependencies
ProjectRequirements --> DevDependencies
note for ProjectRequirements "Python version upgraded from 3.8+ to 3.9+"
note for Dependencies "Dependencies versions bumped"
note for DevDependencies "Moved to poetry.group.dev.dependencies"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mochipon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Remove Python 3.14 from CI configuration as it has not been released yet. Stick to testing against released Python versions (3.9-3.13).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
c79dfec
to
6b75035
Compare
6b75035
to
d3ee094
Compare
Code Climate has analyzed commit 8d3d46b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.6% (-1.8% change). View more on Code Climate. |
Summary by Sourcery
Upgrade Poetry to v2 and Python to 3.9+, along with other dependencies. Replace Flake8, Black, and isort with Ruff. Update pre-commit hooks and CI workflows to reflect these changes.
Build:
CI:
Tests: