-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker impress dev #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerize the frontend development environment to make it easy to display the frontend development environment in the browser. We don't mix it with the command `make run` to let it kind of optional to run the frontend in a docker container. We let it optional because the hot reload doesn't work well in the docker container. The volume synch make it a bit slower as well. So, we let the developer decide to run the frontend in a docker container or not.
AntoLC
added a commit
that referenced
this pull request
Jul 2, 2024
Added: - Manage the document's right (#75) - Update document (#68) - Remove document (#68) - (docker) dockerize dev frontend (#63) - (backend) list users with email filtering (#79) - (frontend) add user to a document (#52) - (frontend) invite user to a document (#52) - (frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - (frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - (frontend) Add beta tag on logo (#121) Changed: - Change site from Impress to Docs (#76) - Generate PDF from a modal (#68) - 🔧 (helm) sticky session by request_uri for signaling server (#78) - (frontend) change logo (#84) - (frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - Fix the break line when generate PDF (#84) Delete: - Remove trigger workflow on push tags on CI (#68) - (frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 2, 2024
Added: - Manage the document's right (#75) - Update document (#68) - Remove document (#68) - (docker) dockerize dev frontend (#63) - (backend) list users with email filtering (#79) - (frontend) add user to a document (#52) - (frontend) invite user to a document (#52) - (frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - (frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - (frontend) Add beta tag on logo (#121) Changed: - Change site from Impress to Docs (#76) - Generate PDF from a modal (#68) - 🔧 (helm) sticky session by request_uri for signaling server (#78) - (frontend) change logo (#84) - (frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - Fix the break line when generate PDF (#84) Delete: - Remove trigger workflow on push tags on CI (#68) - (frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 3, 2024
Added: - Manage the document's right (#75) - Update document (#68) - Remove document (#68) - (docker) dockerize dev frontend (#63) - (backend) list users with email filtering (#79) - (frontend) add user to a document (#52) - (frontend) invite user to a document (#52) - (frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - (frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - (frontend) Add beta tag on logo (#121) Changed: - Change site from Impress to Docs (#76) - Generate PDF from a modal (#68) - 🔧 (helm) sticky session by request_uri for signaling server (#78) - (frontend) change logo (#84) - (frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - Fix the break line when generate PDF (#84) Delete: - Remove trigger workflow on push tags on CI (#68) - (frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 3, 2024
Added: - Manage the document's right (#75) - Update document (#68) - Remove document (#68) - (docker) dockerize dev frontend (#63) - (backend) list users with email filtering (#79) - (frontend) add user to a document (#52) - (frontend) invite user to a document (#52) - (frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - (frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - (frontend) Add beta tag on logo (#121) Changed: - Change site from Impress to Docs (#76) - Generate PDF from a modal (#68) - 🔧 (helm) sticky session by request_uri for signaling server (#78) - (frontend) change logo (#84) - (frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - Fix the break line when generate PDF (#84) Delete: - Remove trigger workflow on push tags on CI (#68) - (frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 3, 2024
Added: - 🛂(frontend) Manage the document's right (#75) - ✨(frontend) Update document (#68) - ✨(frontend) Remove document (#68) - 🐳(docker) dockerize dev frontend (#63) - 👔(backend) list users with email filtering (#79) - ✨(frontend) add user to a document (#52) - ✨(frontend) invite user to a document (#52) - 🛂(frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - 🌐(frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - ⚗️(frontend) Add beta tag on logo (#121) Changed: - ♻️(frontend) Change site from Impress to Docs (#76) - ✨(frontend) Generate PDF from a modal (#68) - 🔧(helm) sticky session by request_uri for signaling server (#78) - ♻️(frontend) change logo (#84) - ♻️(frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - 🐛(frontend) Fix the break line when generate PDF (#84) Delete: - 💚(CI) Remove trigger workflow on push tags on CI (#68) - 🔥(frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 3, 2024
Added: - 🛂(frontend) Manage the document's right (#75) - ✨(frontend) Update document (#68) - ✨(frontend) Remove document (#68) - 🐳(docker) dockerize dev frontend (#63) - 👔(backend) list users with email filtering (#79) - ✨(frontend) add user to a document (#52) - ✨(frontend) invite user to a document (#52) - 🛂(frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - 🌐(frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - ⚗️(frontend) Add beta tag on logo (#121) Changed: - ♻️(frontend) Change site from Impress to Docs (#76) - ✨(frontend) Generate PDF from a modal (#68) - 🔧(helm) sticky session by request_uri for signaling server (#78) - ♻️(frontend) change logo (#84) - ♻️(frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - 🐛(frontend) Fix the break line when generate PDF (#84) Delete: - 💚(CI) Remove trigger workflow on push tags on CI (#68) - 🔥(frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 3, 2024
Added: - 🛂(frontend) Manage the document's right (#75) - ✨(frontend) Update document (#68) - ✨(frontend) Remove document (#68) - 🐳(docker) dockerize dev frontend (#63) - 👔(backend) list users with email filtering (#79) - ✨(frontend) add user to a document (#52) - ✨(frontend) invite user to a document (#52) - 🛂(frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - 🌐(frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - ⚗️(frontend) Add beta tag on logo (#121) Changed: - ♻️(frontend) Change site from Impress to Docs (#76) - ✨(frontend) Generate PDF from a modal (#68) - 🔧(helm) sticky session by request_uri for signaling server (#78) - ♻️(frontend) change logo (#84) - ♻️(frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - 🐛(frontend) Fix the break line when generate PDF (#84) Delete: - 💚(CI) Remove trigger workflow on push tags on CI (#68) - 🔥(frontend) Remove coming soon page (#121)
AntoLC
added a commit
that referenced
this pull request
Jul 3, 2024
Added: - 🛂(frontend) Manage the document's right (#75) - ✨(frontend) Update document (#68) - ✨(frontend) Remove document (#68) - 🐳(docker) dockerize dev frontend (#63) - 👔(backend) list users with email filtering (#79) - ✨(frontend) add user to a document (#52) - ✨(frontend) invite user to a document (#52) - 🛂(frontend) manage members (update role / list / remove) (#81) - ✨(frontend) offline mode (#88) - 🌐(frontend) translate cgu (#83) - ✨(service-worker) offline doc management (#94) - ⚗️(frontend) Add beta tag on logo (#121) Changed: - ♻️(frontend) Change site from Impress to Docs (#76) - ✨(frontend) Generate PDF from a modal (#68) - 🔧(helm) sticky session by request_uri for signaling server (#78) - ♻️(frontend) change logo (#84) - ♻️(frontend) pdf has title doc (#84) - ⚡️(e2e) unique login between tests (#80) - ⚡️(CI) improve e2e job (#86) - ♻️(frontend) improve the error and message info ui (#93) - ✏️(frontend) change all occurences of pad to doc (#99) Fixed: - 🐛(frontend) Fix the break line when generate PDF (#84) Delete: - 💚(CI) Remove trigger workflow on push tags on CI (#68) - 🔥(frontend) Remove coming soon page (#121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
🐋Dockerize the frontend development environment to make it easy to display the frontend development environment in the browser.
We don't mix it with the command
make run
to let it kind of optional to run the frontend in a docker container.We let it optional because the hot reload doesn't work well in the docker container (only windows ?)
So, we let the developer decide to run the frontend in a docker container or not.
How to do
As before:
make bootstrap
Then go to: http://localhost:3000