✨(models/api) allow inviting external users to a document by their email #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
reviewed
May 14, 2024
There was a problem hiding this comment.
I can see the tests failed probably because mail/html/invitation.html is not generated.
I have a question about that, why the mail templates are not git versioned ? If we versioned our templates, we will not have to build them constantly in the CI or in the make bootstrap.
Otherwise they can be generated like that in the CI:
See: suitenumerique/people@f6d5f73
AntoLC
reviewed
May 14, 2024
|
@AntoLC I think email templates should not be persisted for reason of "unicity of information". As long as we are able to generate the content, it is technically not part of our source code in my opinion. |
|
@AntoLC I pushed a fixup. The PR is ready for further review! |
sampaccoud
force-pushed
the
add-user-invitations
branch
from
cb9cc2d to
65671ed
Compare
sampaccoud
force-pushed
the
add-user-invitations
branch
from
65671ed to
d89f146
Compare
Running the container as root will install npm modules with root access rights and generate issues when running the application with the logged in user as we do it with Docker Compose.
We want to be able to share a document with a person even if this person does not have an account in impress yet. This code is ported from https://github.com/numerique-gouv/people.
sampaccoud
force-pushed
the
add-user-invitations
branch
from
d89f146 to
f246d11
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to be able to share a document with a person even if this person does not have an account in impress yet.
Proposal
This code is ported from https://github.com/numerique-gouv/people and adapted to the differences in
Impress:Identityobject, the identity is carried by theUser