Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛(backend) race condition creation issue #556

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Jan 15, 2025

Purpose

3 requests we able to create a document:

  • POST document
  • GET collaboration-auth
  • GET media-auth

If the 2 last were faster than the first, a document was created without the necessary informations.

Proposal

  • 🐛(backend) creation race condition
  • ✏️(backend) fix read_only_fields is_favorite

@AntoLC AntoLC added bug Something isn't working backend labels Jan 15, 2025
@AntoLC AntoLC self-assigned this Jan 15, 2025
@AntoLC AntoLC changed the title 🐛Race creation issue 🐛(backend) race condition creation issue Jan 15, 2025
3 requests we able to create a document:
- POST document request
- GET collaboration-auth
- GET media-auth

If the 2 last were faster than the first, a
document was created without the necessary
informations.
is_favorite has a typo error.
This commit fixes it.
@AntoLC AntoLC force-pushed the fix/race_creation_issue branch from a2454ee to b5628c4 Compare January 15, 2025 11:03
@AntoLC AntoLC enabled auto-merge (rebase) January 15, 2025 11:06
@AntoLC AntoLC merged commit 342fc2a into main Jan 15, 2025
16 of 17 checks passed
@AntoLC AntoLC deleted the fix/race_creation_issue branch January 15, 2025 11:13
@AntoLC AntoLC mentioned this pull request Jan 15, 2025
sampaccoud added a commit that referenced this pull request Jan 21, 2025
These methods were involved in a bug that was fixed without first
evidencing the error in a test:
#556

Fixes #567
sampaccoud added a commit that referenced this pull request Jan 28, 2025
These methods were involved in a bug that was fixed without first
evidencing the error in a test:
#556

Fixes #567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants