✨Export pdf / docx front side #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/export-front-side
branch
2 times, most recently
from
a5a72eb to
7dad46f
Compare
AntoLC
force-pushed
the
feature/export-front-side
branch
from
7dad46f to
c3db0f5
Compare
PanchoutNathan
approved these changes
Jan 9, 2025
sampaccoud
reviewed
Jan 11, 2025
| @@ -72,7 +72,6 @@ RUN apk add \ | |||
| gettext \ | |||
| gdk-pixbuf \ | |||
| libffi-dev \ | |||
| pandoc \ | |||
There was a problem hiding this comment.
Look at the initial commit, I think more dependencies can be removed that are linked to exports.
| @@ -50,13 +50,11 @@ dependencies = [ | |||
| "openai==1.58.1", | |||
| "psycopg[binary]==3.2.3", | |||
| "PyJWT==2.10.1", | |||
| "pypandoc==1.14", | |||
There was a problem hiding this comment.
looking at git history you can remove more dependencies like for example python-frontmatter and probably nested-multipart-parser
There was a problem hiding this comment.
python-frontmatteris used for the translationsnested-multipart-parserfor the swagger
We have added the export to pdf and docx feature to the front side. Thanks to that, the images are now correctly exported even when the doc is private. To be able to export the doc, the data must be in blocknote format, for legacy purpose, we have to convert the template to blocknote format before exporting it.
The export is managed by the frontend, so we don't need the code related to the export in the backend side anymore.
Add some changelog entries that can be useful to display in the release notes.
All the uploaded files had the content-type set to `application/octet-stream`. It create issues when the file is downloaded from the frontend because the browser doesn't know how to handle the file. We improved the mimetype database and we now determine the content-type of the file and set it to the file object.
AntoLC
force-pushed
the
feature/export-front-side
branch
from
c3db0f5 to
06660c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We have added the export to pdf and docx feature to the front side.
Thanks to that, the images are now correctly exported even when the doc is private.
To be able to export the doc, the data must be in Blocknote format, for legacy purpose, we have to convert the template to Blocknote format before exporting it.
close #202
Proposal
Demo
scrnli_072OH9VH48IDJQ.webm