♻️Collaboration process #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/collaboration-process
branch
3 times, most recently
from
f416aa7 to
69c2c91
Compare
Many routes were in the server.ts file, now they are in their own files in the handlers folder. The server.ts file is now AppServer that handles the routes. We split as well the tests.
Add cors middlewares to y-provider server. It will control how clients connect to the server with http requests.
When a task was already existing, we were not updating it. This commit fixes that.
We created useProviderStore, a store dedicated to managing the provider of the document. We created as well a new hook useCollaboration, it will be use to interact with the provider store. This refacto is a first step to implement the long polling.
AntoLC
force-pushed
the
refacto/collaboration-process
branch
from
69c2c91 to
904fd05
Compare
PanchoutNathan
approved these changes
Dec 24, 2024
Comment on lines
+66
to
+68
| setTimeout(() => { | ||
| isInitializing = false; | ||
| }, 1000); |
There was a problem hiding this comment.
task.observe triggers the task lightly after you bind it to it, it seems like a bug, it is due to the architecture of y.js apparently. We want to exec the task only when we trigger it from broadcast method, so isInitializing is a trick to blocked this initial trigger.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It is the first step to introduce the long polling feature (see: #517)
We improve the architecture of the collaboration server, it will help us to introduce new routes without impacting the other routes.
We create
useProviderStoreon the frontend side, it will be dedicated to the provider.We add as well
useCollaborationhook, that will manage the collaboration connections.Proposal