-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: atrium-repo
#272
base: main
Are you sure you want to change the base?
feat: atrium-repo
#272
Changes from all commits
bfb8c17
682f0e4
e33db08
cb49514
1d4c101
d633238
5343362
e9532bb
4e2f052
a1468de
8ce976a
e80ee06
98604a3
752f073
9b91158
bee8f13
f7fa5a9
63eb5e5
daa6165
381c304
16db1bd
ce8e32b
d281bd6
973b06c
caa3681
cb7222c
b4e8a99
5ce2e07
f7b910e
9665d2b
91bee28
f01c0ba
f31f338
5cfc9c3
4a921c1
50ca94d
baffd15
5f9edb4
7612064
5da91d0
cb8e8c0
ef20156
bbd9cd1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,22 @@ members = [ | |
"atrium-api", | ||
"atrium-common", | ||
"atrium-crypto", | ||
"atrium-repo", | ||
"atrium-xrpc", | ||
"atrium-xrpc-client", | ||
"atrium-oauth/identity", | ||
"atrium-oauth/oauth-client", | ||
"bsky-cli", | ||
"bsky-sdk", | ||
|
||
# "examples/concurrent", | ||
"examples/firehose", | ||
] | ||
# Examples show how to use the latest published crates, not the workspace state. | ||
exclude = [ | ||
"examples/concurrent", | ||
"examples/firehose", | ||
"examples/video", | ||
# "examples/concurrent", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason why these are no longer excluded? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah - I had forgotten about this. The decision to have examples demonstrate the last public release seems to be an unusual one. I haven't ever seen this be done for any other Rust library. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed. The current policy of using the latest release version does not allow us to use newly added packages. We've discussed this before and made it the way it is now, But maybe we should reconsider. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed - I think it would be wise to reconsider :) One potential alternative to allow people to find examples for the previously released version would be to create git tags upon release and instruct users to look for the corresponding tag. |
||
# "examples/firehose", | ||
# "examples/video", | ||
] | ||
resolver = "2" | ||
|
||
|
@@ -27,13 +31,17 @@ keywords = ["atproto", "bluesky"] | |
|
||
[workspace.dependencies] | ||
# Intra-workspace dependencies | ||
atrium-api = { version = "0.24.10", path = "atrium-api", default-features = false } | ||
atrium-api = { version = "0.24.10", path = "atrium-api" } | ||
atrium-common = { version = "0.1.0", path = "atrium-common" } | ||
atrium-crypto = { version = "0.1.2", path = "atrium-crypto" } | ||
atrium-identity = { version = "0.1.0", path = "atrium-oauth/identity" } | ||
atrium-xrpc = { version = "0.12.0", path = "atrium-xrpc" } | ||
atrium-xrpc-client = { version = "0.5.10", path = "atrium-xrpc-client" } | ||
bsky-sdk = { version = "0.1.15", path = "bsky-sdk" } | ||
|
||
# async in streams | ||
async-stream = "0.3" | ||
|
||
# DAG-CBOR codec | ||
ipld-core = { version = "0.4.1", default-features = false, features = ["std"] } | ||
serde_ipld_dagcbor = { version = "0.6.0", default-features = false, features = ["std"] } | ||
|
@@ -49,6 +57,7 @@ serde = "1.0.202" | |
serde_bytes = "0.11.9" | ||
serde_html_form = "0.2.6" | ||
serde_json = "1.0.125" | ||
unsigned-varint = "0.8" | ||
|
||
# Cryptography | ||
ecdsa = "0.16.9" | ||
|
@@ -68,7 +77,8 @@ hickory-resolver = "0.24.1" | |
http = "1.1.0" | ||
lru = "0.12.4" | ||
moka = "0.12.8" | ||
tokio = { version = "1.39", default-features = false } | ||
tokio = { version = "1.39", default-features = false, features = ["io-util"] } | ||
tokio-util = "0.7" | ||
|
||
# HTTP client integrations | ||
isahc = "1.7.2" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# Changelog | ||
All notable changes to this project will be documented in this file. | ||
|
||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | ||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
||
## [Unreleased] | ||
|
||
Initial release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to include anything related to a specific editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this line because VSCode annoyingly creates this folder automatically (likely due to the Copilot extension being broken and populating a
settings.json
).If it isn't present, it's almost certain that I or someone else may accidentally commit this folder.
If you don't want to have a line that explicitly mentions VSCode, another alternative you could consider is changing this
.gitignore
file to an allowlist.Here's an example from one of my other projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each individual's settings related to the editor should have their own global ignore settings, and I don't want to include changes on the repository side for that.
According to
man gitignore
:I believe that editor related ignore settings should be written there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I still persuade you to reconsider? :)
This is commonly done in many projects - for example, Rust itself has a .gitignore file checked in with this line present.
I do work with some projects that are exceptions to this rule and feel like a global setting would be more cumbersome than helpful.