Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement std::fmt::Display for all Error types #140

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

futsuuu
Copy link
Contributor

@futsuuu futsuuu commented Mar 16, 2024

This PR makes it easier for projects that use the atrium_api to create easy-to-read error messages.

@sugyan sugyan self-requested a review March 16, 2024 14:22
Copy link
Owner

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice feature!
Looks great, even the code generation is well-modified.

@@ -2,5 +2,7 @@ atrium-api/src/app.rs linguist-generated=true
atrium-api/src/app/** linguist-generated=true
atrium-api/src/com.rs linguist-generated=true
atrium-api/src/com/** linguist-generated=true
atrium-api/src/tools.rs linguist-generated=true
atrium-api/src/tools/** linguist-generated=true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add these when I made the changes that created these files earlier. Thank you very much!

@sugyan sugyan merged commit 336aed9 into sugyan:main Mar 16, 2024
7 checks passed
@futsuuu futsuuu deleted the feat/display-err branch March 16, 2024 14:32
@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants