Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add a job to check that the wasm32-wasi target builds #117

Merged
merged 2 commits into from
Feb 27, 2024
Merged

CI: Add a job to check that the wasm32-wasi target builds #117

merged 2 commits into from
Feb 27, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Feb 23, 2024 •
edited
Loading

This helps to ensure no regressions occur while changes are being made to enable a WASM-compatible HTTP client to be used in atrium-xrpc-client.

Part of #116.

@str4d str4d mentioned this pull request Feb 23, 2024
Closed
sugyan
sugyan reviewed Feb 24, 2024
View reviewed changes
Copy link
Owner

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I would like to modify the client so that the build succeeds while keeping this to pass, or even with xrpc-client with default-features enabled.

.github/workflows/wasm.yml Show resolved Hide resolved
@str4d str4d mentioned this pull request Feb 27, 2024
Merged
@sugyan sugyan merged commit 3838d78 into sugyan:main Feb 27, 2024
6 checks passed
@str4d str4d deleted the 116-wasm-ci branch February 27, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugyan sugyan sugyan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @sugyan