-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce dedicated types for DID and handle Lexicon string formats #103
Conversation
I've opened this PR to get review on the general approach, as well as the types that were simpler to implement. I am also working locally on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read the documentation.
Lexicon requires the intersection of RFC 3339 and ISO 8601, and chrono
supports RFC 3339 with parse_from_rfc3339
, but just because it can parse it does not mean it conforms to ISO 8601. So, if we want to implement it correctly, we need to exclude the ones that are not correct as ISO 8601. Am I correct in my understanding that this is the case?
If this library is more permissive than the spec (though it would need documentation), then all input for RFC 3339 format should be fine if parse succeeds, and the output in to_rfc3339
should meet Lexicon's requirements. I suspect that would work well enough, but what do you think?
Correct, that is indeed the case for parsing. I think this is primarily things like not parsing the
For serialization, I'll be using |
7b86f55
to
6060a7c
Compare
6060a7c
to
f3d18f8
Compare
Rebased on |
Thank you very much. |
No description provided.