fix: Remove Arc from xrpc-clients (#206)

sugyan · Jul 28, 2024 · af69f1b · af69f1b
1 parent 75673d0
commit af69f1b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/atrium-xrpc-client/src/isahc.rs b/atrium-xrpc-client/src/isahc.rs
@@ -17,7 +17,7 @@ use std::sync::Arc;
 #[derive(Clone)]
 pub struct IsahcClient {
     base_uri: String,
-    client: Arc<Client>,
+    client: Client,
 }
 
 impl IsahcClient {
@@ -50,10 +50,9 @@ impl IsahcClientBuilder {
     pub fn build(self) -> IsahcClient {
         IsahcClient {
             base_uri: self.base_uri,
-            client: Arc::new(
-                self.client
-                    .unwrap_or(Client::new().expect("failed to create isahc client")),
-            ),
+            client: self
+                .client
+                .unwrap_or(Client::new().expect("failed to create isahc client")),
         }
     }
 }

diff --git a/atrium-xrpc-client/src/reqwest.rs b/atrium-xrpc-client/src/reqwest.rs
@@ -3,7 +3,6 @@ use async_trait::async_trait;
 use atrium_xrpc::http::{Request, Response};
 use atrium_xrpc::{HttpClient, XrpcClient};
 use reqwest::Client;
-use std::sync::Arc;
 
 /// A [`reqwest`] based asynchronous client to make XRPC requests with.
 ///
@@ -17,7 +16,7 @@ use std::sync::Arc;
 #[derive(Clone)]
 pub struct ReqwestClient {
     base_uri: String,
-    client: Arc<Client>,
+    client: Client,
 }
 
 impl ReqwestClient {
@@ -50,7 +49,7 @@ impl ReqwestClientBuilder {
     pub fn build(self) -> ReqwestClient {
         ReqwestClient {
             base_uri: self.base_uri,
-            client: Arc::new(self.client.unwrap_or_default()),
+            client: self.client.unwrap_or_default(),
         }
     }
 }