Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better frontend #227

Merged
merged 5 commits into from
Oct 7, 2018
Merged

Better frontend #227

merged 5 commits into from
Oct 7, 2018

Conversation

sarahperea
Copy link
Contributor

Changed 'Halloween Page' button's appearance and applied other fixes for issue here: #212

@sudz123 sudz123 merged commit 2146518 into sudz123:master Oct 7, 2018
@sudz123
Copy link
Owner

sudz123 commented Oct 7, 2018

@sarahperea don't the images look out of context? How about new images 💃 ? Also see how the next button is not working? I guess a better implementation of the next and previous buttons would be to fast forward the image scroll forwards/ backwards respectively.

@sarahperea sarahperea deleted the better-frontend branch October 7, 2018 14:42
@sudz123
Copy link
Owner

sudz123 commented Oct 7, 2018

Also I guess the video would get more attention if placed somewhere above. Maybe above the maintainers? Not sure about this one..

@sarahperea
Copy link
Contributor Author

@sudz123 alright I'll try to fix the 'next' button. :)
Re: images, I don't have any idea what to put there?
On video, I'll try to PR and place it above the maintainers. :)

@sarahperea sarahperea restored the better-frontend branch October 8, 2018 06:44
@sarahperea sarahperea deleted the better-frontend branch October 8, 2018 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants